Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot_server): send and save csv rtp files for runs #15857

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Jul 31, 2024

re AUTH-591

Overview

Send and save the CSV RTPs used in protocol runs to the new table created in the database, and hook it up to the GET endpoint that fetches all the data files used in analysis and run.

Test Plan and Hands on Testing

  • run test files to ensure that csv rtps get insert to the new run_csv_rtp_table and able to get them from the table

Changelog

  • Added run_csv_rtp_table to schema_6.py file
  • Added runTimeParameterFiles field to the run creation request model
  • Passed rtp files input onto the Run Orchestrator’s load process
  • Added insert_csv_rtp() and get_all_csv_rtp() function
  • Updated get_reference_data_files() to add file referenced in runs
  • Updated tests

Review requests

Risk assessment

@syao1226 syao1226 requested a review from a team as a code owner July 31, 2024 18:36
@syao1226 syao1226 closed this Jul 31, 2024
@syao1226 syao1226 reopened this Aug 1, 2024
@syao1226 syao1226 closed this Aug 1, 2024
@syao1226 syao1226 reopened this Aug 1, 2024
@syao1226 syao1226 marked this pull request as draft August 1, 2024 15:09
@syao1226 syao1226 requested a review from sanni-t August 1, 2024 21:06
@syao1226 syao1226 marked this pull request as ready for review August 2, 2024 18:57
@syao1226 syao1226 requested a review from jbleon95 August 2, 2024 19:17
@sanni-t sanni-t requested a review from a team as a code owner August 2, 2024 19:51
@syao1226 syao1226 changed the base branch from edge to internal-release_0.8.0 August 2, 2024 20:42
@syao1226 syao1226 requested a review from a team as a code owner August 2, 2024 20:42
@syao1226 syao1226 requested review from shlokamin and removed request for a team August 2, 2024 20:42
@syao1226 syao1226 changed the base branch from internal-release_0.8.0 to chore_release-8.0.0 August 2, 2024 20:42
Copy link
Contributor

@jbleon95 jbleon95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Looks good to me!

@sanni-t sanni-t merged commit 47f15dc into chore_release-8.0.0 Aug 2, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants